[webkit-reviews] review granted: [Bug 182644] The referer header is not set after redirect : [Attachment 336824] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 182644: The referer header is not set after redirect
https://bugs.webkit.org/show_bug.cgi?id=182644

Attachment 336824: Patch

https://bugs.webkit.org/attachment.cgi?id=336824&action=review




--- Comment #37 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 336824
  --> https://bugs.webkit.org/attachment.cgi?id=336824
Patch

LGTM

View in context: https://bugs.webkit.org/attachment.cgi?id=336824&action=review

> Source/WebCore/loader/SubresourceLoader.cpp:575
>	   cleanHTTPRequestHeadersForAccessControl(newRequest);

As a follow-up, it might be good to update
cleanHTTPRequestHeadersForAccessControl to no longer strip out Referrer.
There is another call site in ServiceWorker where we can explicitly clear the
referrer since it is passed as an independent parameter.
Then we may be able to call updateReferrerPolicy and just after call
updateRequestReferrer.

> Source/WebCore/platform/ReferrerPolicy.cpp:14
> + *	  * Neither the name of Google Inc. nor the names of its

Should be updated probably.