[webkit-reviews] review granted: [Bug 184239] Add infrastructure to relax SSL for allowed hosts in DumpRenderTree and WebKitTestRunner : [Attachment 336995] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 184239: Add infrastructure to relax SSL for allowed hosts in DumpRenderTree
and WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=184239

Attachment 336995: Patch

https://bugs.webkit.org/attachment.cgi?id=336995&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 336995
  --> https://bugs.webkit.org/attachment.cgi?id=336995
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336995&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:1253
> +	       [NSURLRequest setAllowsAnyHTTPSCertificate:YES
forHost:[[NSString alloc] initWithUTF8String:host.c_str()]];

This leaks the string (as we don't seem to be using ARC in DRT).

> Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:57
> +	   [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:host];

What are the iOS versions where we still perform network loading from the
WebContent process?

> Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:99
> +    for (auto& host : m_allowedHosts)
> +	   [NSURLRequest setAllowsAnyHTTPSCertificate:YES forHost:host];

What are the macOS versions where we still perform network loading from the
WebContent process?

> Tools/WebKitTestRunner/TestController.cpp:1763
> +	       return std::any_of(m_allowedHosts.begin(), m_allowedHosts.end(),
[host] (const std::string& allowedHost) { return host == allowedHost; });

Wouldn't m_allowedHosts.find() work here?