[webkit-reviews] review granted: [Bug 183346] [GTK] NetworkProcess from WebKitGtk+ 2.19.9x SIGSEVs in NetworkStorageSession (secret search callback) : [Attachment 336974] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 183346: [GTK] NetworkProcess from WebKitGtk+ 2.19.9x SIGSEVs in
NetworkStorageSession (secret search callback)
https://bugs.webkit.org/show_bug.cgi?id=183346

Attachment 336974: Patch

https://bugs.webkit.org/attachment.cgi?id=336974&action=review




--- Comment #23 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 336974
  --> https://bugs.webkit.org/attachment.cgi?id=336974
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336974&action=review

The Fedora bug report is not for a Flatpak.

> Source/WebCore/ChangeLog:8
> +	   This might happen if a request is cancelled right after the password
request starts and before it finishes. We

Aha!

> Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:240
> +	       g_list_foreach(elements.get(),
reinterpret_cast<GFunc>(g_object_unref), nullptr);

It took me a while to convince myself that there was no leak in the early
return up above. GUniquePtr<GList> is similar to the WlUniquePtr<wl_display>
case, in that we really need more flexibility in choosing the deleter func to
use. I wonder if it would be possible to make a syntax like GUniquePtr<GList,
g_object_unref> do the right thing.