[webkit-reviews] review granted: [Bug 184233] [Enchant] Clean up TextCheckerEnchant : [Attachment 336979] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 08:02:31 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 184233: [Enchant] Clean up TextCheckerEnchant
https://bugs.webkit.org/show_bug.cgi?id=184233

Attachment 336979: Patch

https://bugs.webkit.org/attachment.cgi?id=336979&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 336979
  --> https://bugs.webkit.org/attachment.cgi?id=336979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336979&action=review

Nice

> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:43
> +    if (!dictionary)
> +	   return;

Remember C++ guarantees this func is only called if the parameter is nonnull,
so remove this.


More information about the webkit-reviews mailing list