[webkit-reviews] review denied: [Bug 184127] [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library : [Attachment 336969] Patch

[bugzilla-daemon at webkit.org]

Fujii Hironori <Hironori.Fujii at sony.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 184127: [CMake] WebKit should link to WebCore as a PRIVATE library if
WebCore is a static library
https://bugs.webkit.org/show_bug.cgi?id=184127

Attachment 336969: Patch

https://bugs.webkit.org/attachment.cgi?id=336969&action=review




--- Comment #9 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 336969
  --> https://bugs.webkit.org/attachment.cgi?id=336969
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336969&action=review

>> Source/WebCore/CMakeLists.txt:1994
>> +	target_link_libraries(WebCore PUBLIC ANGLESupport)
> 
> ANGLESupport must be PRIVATE

No.
I tried PRIVATE, but I got compilation errors. I'll attach the error message
for the records, tomorrow.

>> Source/WebKit/PlatformGTK.cmake:461
>> +list(APPEND WebKit_PRIVATE_LIBRARIES
> 
> There is no real need for new variable - just add 'PUBLIC' and 'PRIVATE'
keywords to WebKit_LIBRARIES.

I think I need to switch back to PUBLIC again.

> list(APPEND WebKit_PRIVATE_LIBRARIES PRIVATE WebCore PUBLIC)

I'll remake the patch.