[webkit-reviews] review granted: [Bug 183740] [MIPS] Optimize JIT code generated by methods with TrustedImm32 operand : [Attachment 336856] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 1 12:35:04 PDT 2018


Yusuke Suzuki <utatane.tea at gmail.com> has granted Stanislav Ocovaj
<stanislav.ocovaj at rt-rk.com>'s request for review:
Bug 183740: [MIPS] Optimize JIT code generated by methods with TrustedImm32
operand
https://bugs.webkit.org/show_bug.cgi?id=183740

Attachment 336856: Patch

https://bugs.webkit.org/attachment.cgi?id=336856&action=review




--- Comment #9 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 336856
  --> https://bugs.webkit.org/attachment.cgi?id=336856
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336856&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2141
> +	       ASSERT(0);

Change this to ASSERT_NOT_REACHED(); too.


More information about the webkit-reviews mailing list