[webkit-reviews] review granted: [Bug 177681] [Settings] Replace SettingsMacros.h with a generated base class for Settings : [Attachment 322301] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 177681: [Settings] Replace SettingsMacros.h with a generated base class for
Settings
https://bugs.webkit.org/show_bug.cgi?id=177681

Attachment 322301: Patch

https://bugs.webkit.org/attachment.cgi?id=322301&action=review




--- Comment #29 from Darin Adler <darin at apple.com> ---
Comment on attachment 322301
  --> https://bugs.webkit.org/attachment.cgi?id=322301
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322301&action=review

I am not sure about the build failure on Windows.

> Source/WebCore/ChangeLog:16
> +	     exists for the IDL generator, and expect and enum to be in a
header of the

typo: "and" -> "an"

> Source/WebCore/Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:106
> +    if setting.type == 'IntSize':
> +	   return "\"IntSize.h\""
> +
> +    # Default to using the type name for the include
> +    return "\"" + setting.type + ".h\""

Looks like the IntSize special case is not needed.

> Source/WebCore/Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:148
> +    # FIXME: When webcoreExport is "", line has extra space.

I don’t understand. That does not seem to be true.