[webkit-reviews] review granted: [Bug 177698] [iOS WK2] API test EditorStateTests.ContentViewHasTextInContentEditableElement is a flaky failure : [Attachment 322282] Fix some awkward ChangeLog wording

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 30 13:23:44 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 177698: [iOS WK2] API test
EditorStateTests.ContentViewHasTextInContentEditableElement is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=177698

Attachment 322282: Fix some awkward ChangeLog wording

https://bugs.webkit.org/attachment.cgi?id=322282&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 322282
  --> https://bugs.webkit.org/attachment.cgi?id=322282
Fix some awkward ChangeLog wording

View in context: https://bugs.webkit.org/attachment.cgi?id=322282&action=review

> Source/WebCore/editing/VisibleUnits.cpp:1895
> -    Vector<UChar32> characters(maxCharacters);
> +    Vector<UChar32> characters(maxCharacters, 0);

Can we just make this an array of length 3 as in?
UChar32 maxCharacters[maxCharacters] = {0};
or at least give it an inline capacity so that it won't do a heap allocation?


More information about the webkit-reviews mailing list