[webkit-reviews] review granted: [Bug 177700] Share more pasteboard code between iOS and macOS and remove dependency on Settings : [Attachment 322279] Cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 29 22:29:11 PDT 2017


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 177700: Share more pasteboard code between iOS and macOS and remove
dependency on Settings
https://bugs.webkit.org/show_bug.cgi?id=177700

Attachment 322279: Cleanup

https://bugs.webkit.org/attachment.cgi?id=322279&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 322279
  --> https://bugs.webkit.org/attachment.cgi?id=322279
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=322279&action=review

> Source/WebCore/dom/DataTransfer.cpp:146
> +    if (Settings::customPasteboardDataEnabled() &&
!Pasteboard::isSafeTypeForDOMToReadAndWrite(type))

Shouldn't this be !Pasteboard::isSafeTypeForDOMToReadAndWrite(normalizedType)
here? (instead of the non-normalized type)


More information about the webkit-reviews mailing list