[webkit-reviews] review granted: [Bug 177314] Web Inspector: Styles Redesign: support undo/redo of manual edits : [Attachment 322254] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 177314: Web Inspector: Styles Redesign: support undo/redo of manual edits
https://bugs.webkit.org/show_bug.cgi?id=177314

Attachment 322254: Patch

https://bugs.webkit.org/attachment.cgi?id=322254&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 322254
  --> https://bugs.webkit.org/attachment.cgi?id=322254
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322254&action=review

r=me

>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.
js:85
> +    attached()
> +    {
> +	   if (this._style)
> +	      
this._style.addEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged,
this._propertiesChanged, this);
> +    }
> +
> +    detached()
> +    {
> +	   if (this._style)
> +	      
this._style.removeEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged,
this._propertiesChanged, this);
> +    }

I think after our discussion we might be fine not doing this. Given the style
-> section -> editor relationship.