[webkit-reviews] review granted: [Bug 177696] Remove redundant RenderObject::selectionRoot and dependencies : [Attachment 322262] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 29 18:58:06 PDT 2017
Ryosuke Niwa <rniwa at webkit.org> has granted zalan <zalan at apple.com>'s request
for review:
Bug 177696: Remove redundant RenderObject::selectionRoot and dependencies
https://bugs.webkit.org/show_bug.cgi?id=177696
Attachment 322262: Patch
https://bugs.webkit.org/attachment.cgi?id=322262&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 322262
--> https://bugs.webkit.org/attachment.cgi?id=322262
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=322262&action=review
> Source/WebCore/rendering/RenderView.h:96
> + void selectionStartEnd(unsigned& start, unsigned& end) const {
selectionData().selectionStartEndPositions(start, end); }
Can we rename this to getSelectionStartEnd?
More information about the webkit-reviews
mailing list