[webkit-reviews] review granted: [Bug 21242] [CURL] Should handle redirects in WebCore : [Attachment 322246] patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 21242: [CURL] Should handle redirects in WebCore
https://bugs.webkit.org/show_bug.cgi?id=21242

Attachment 322246: patch

https://bugs.webkit.org/attachment.cgi?id=322246&action=review




--- Comment #18 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 322246
  --> https://bugs.webkit.org/attachment.cgi?id=322246
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322246&action=review

> Source/WebCore/platform/network/ResourceHandle.cpp:173
> +#if !PLATFORM(COCOA) && !USE(CFURLCONNECTION) && !USE(SOUP) && !USE(CURL)

That's everyone.  Let's just get rid of this.

> Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp:281
> +    if ((request.httpMethod() == "GET") || (request.httpMethod() == "HEAD"))

unnecessary parentheses.

> Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp:371
> +    if (protocolHostAndPortAreEqual(m_currentRequest.url(),
response().url())) {
> +	   auto credential = getCredential(m_currentRequest, true);

This is probably ok, but will likely need to be refined.  It ignores the realm
of basic authentication credentials, for example.

> Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp:154
> +    return (httpStatusCode() == 301);

parentheses unnecessary.