[webkit-reviews] review granted: [Bug 177685] Remove SelectionSubtreeRoot::RenderSubtreesMap : [Attachment 322239] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 29 15:04:34 PDT 2017


Andy Estes <aestes at apple.com> has granted zalan <zalan at apple.com>'s request for
review:
Bug 177685: Remove SelectionSubtreeRoot::RenderSubtreesMap
https://bugs.webkit.org/show_bug.cgi?id=177685

Attachment 322239: Patch

https://bugs.webkit.org/attachment.cgi?id=322239&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 322239
  --> https://bugs.webkit.org/attachment.cgi?id=322239
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322239&action=review

> Source/WebCore/rendering/RenderView.cpp:815
> +    std::unique_ptr<OldSelectionData> oldSelectionData =
std::make_unique<OldSelectionData>();

I'd use auto here.


More information about the webkit-reviews mailing list