[webkit-reviews] review granted: [Bug 177654] Add a WebKit Build Archives page : [Attachment 322184] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 29 15:00:54 PDT 2017
Alexey Proskuryakov <ap at webkit.org> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 177654: Add a WebKit Build Archives page
https://bugs.webkit.org/show_bug.cgi?id=177654
Attachment 322184: Patch
https://bugs.webkit.org/attachment.cgi?id=322184&action=review
--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 322184
--> https://bugs.webkit.org/attachment.cgi?id=322184
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=322184&action=review
> Websites/webkit.org/ChangeLog:13
> +2017-09-29 Jon Davis <jond at apple.com>
> +
> + Add a WebKit Build Archives page
> + https://bugs.webkit.org/show_bug.cgi?id=177654
Duplicate ChangeLog.
> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:31
> + if ( is_wp_error($response) )
Coding style: spaces.
> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:69
> + var date = new Date(parseInt(timestamp.innerHTML));
Can we use textContent here?
> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:70
> + timestamp.innerHTML = date.toLocaleDateString('en',
{"timeZoneName":"short","minute":"2-digit","hour":"2-digit","day":"numeric","mo
nth":"long","year":"numeric"})
Ditto.
Also, can you fix the mix of double and single quotes throughout?
> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:77
> + if ( currentLink.length )
Coding style.
> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:83
> + if ( currentList.length )
Coding style.
> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:92
> + if (link.className.indexOf(window.location.hash.replace('#',''))
!== -1)
Coding style: space after comma.
> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:103
> + echo '<meta name="robots" content="nofollow" />';
Please don't use XML self-closing syntax in HTML
More information about the webkit-reviews
mailing list