[webkit-reviews] review granted: [Bug 177667] [WK2][NETWORK_SESSION] Move some authentication-related code to avoid duplication : [Attachment 322209] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 29 14:39:02 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 177667: [WK2][NETWORK_SESSION] Move some authentication-related code to
avoid duplication
https://bugs.webkit.org/show_bug.cgi?id=177667

Attachment 322209: Patch

https://bugs.webkit.org/attachment.cgi?id=322209&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 322209
  --> https://bugs.webkit.org/attachment.cgi?id=322209
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322209&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:233
> +    if ([challenge.protectionSpace.authenticationMethod
isEqualTo:NSURLAuthenticationMethodServerTrust] &&
!NetworkProcess::singleton().canHandleHTTPSServerTrustEvaluation()) {

isEqualToString


More information about the webkit-reviews mailing list