[webkit-reviews] review granted: [Bug 177639] Custom GetterSetterAccessCase does not use the correct slotBase when making call : [Attachment 322224] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 177639: Custom GetterSetterAccessCase does not use the correct slotBase
when making call
https://bugs.webkit.org/show_bug.cgi?id=177639

Attachment 322224: patch

https://bugs.webkit.org/attachment.cgi?id=322224&action=review




--- Comment #6 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 322224
  --> https://bugs.webkit.org/attachment.cgi?id=322224
patch

r=me

I don't see any downside to this approach.

Still, I think it's super weird, and a design booby trap, that we use
"!m_conditionSet.isEmtpy()" to mean "this is a prototype access". Would be nice
to clean that up in the long run. I'm not particularly interested in restoring
the optimization to skip a condition in this case -- I just want to make the
design more obvious and explicit.

You know something is not obvious when it takes three paragraphs and an IRC
conversation to explain :P.