[webkit-reviews] review granted: [Bug 177669] [iOS] Remove unused pre-iOS 11 codepaths for writing to the pasteboard : [Attachment 322198] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 177669: [iOS] Remove unused pre-iOS 11 codepaths for writing to the
pasteboard
https://bugs.webkit.org/show_bug.cgi?id=177669

Attachment 322198: Patch

https://bugs.webkit.org/attachment.cgi?id=322198&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 322198
  --> https://bugs.webkit.org/attachment.cgi?id=322198
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322198&action=review

> Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:55
> +#if TARGET_OS_IOS

I think we usually don't use the platform target conditionals, and prefer
PLATFORM(IOS) && !(PLATFORM(WATCHOS) || PLATFORM(APPLETV)), however sad that
may be. If you don't want to say that everywhere, add a thing like
ENABLE_DATA_DETECTION or HAVE_AVKIT are defined in Platform.h?