[webkit-reviews] review granted: [Bug 177636] Clean up Long Press Selection Tests : [Attachment 322155] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 177636: Clean up Long Press Selection Tests
https://bugs.webkit.org/show_bug.cgi?id=177636

Attachment 322155: Patch

https://bugs.webkit.org/attachment.cgi?id=322155&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 322155
  --> https://bugs.webkit.org/attachment.cgi?id=322155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322155&action=review

>
LayoutTests/fast/events/touch/ios/long-press-then-drag-down-to-change-selected-
text.html:22
> +	       var pressPointX = firstTargetRect.x + firstTargetRect.width/2;

Spaces around operators! Always! :)

>
LayoutTests/fast/events/touch/ios/long-press-then-drag-down-to-change-selected-
text.html:95
> -    <meta name="viewport" content="initial-scale=1">
> +    <meta name="viewport" content="initial-scale=1.0">

This was better before IMO

>
LayoutTests/fast/events/touch/ios/long-press-then-drag-right-to-change-selected
-text.html:59
> +				  
testRunner.runUIScript(touchAndDragFromPointToPoint(dragX2,dragY,dragX,dragY),
function(result) {

Spaces after commas too!