[webkit-reviews] review requested: [Bug 177012] Web Inspector: Styles Redesign: support editing of rule selectors : [Attachment 321902] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 177012: Web Inspector: Styles Redesign: support editing of rule selectors
https://bugs.webkit.org/show_bug.cgi?id=177012

Attachment 321902: Patch

https://bugs.webkit.org/attachment.cgi?id=321902&action=review




--- Comment #5 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 321902
  --> https://bugs.webkit.org/attachment.cgi?id=321902
Patch

After investigating EditingSupport.js, I encountered several issues:
- Unnecessary tabIndex manipulations, that prevents proper focusing order.
- Option-Arrow keys functionality, that can't be turned off at this time.

In addition to this, EditingSupport.js is very old and uses patterns we don't
use for our recent code (such as passing config instance with event listeners).

I'm changing my patch back to r?. I think we need to rewrite EditingSupport at
some point, but I don't want to be blocked by it right now.