[webkit-reviews] review denied: [Bug 177012] Web Inspector: Styles Redesign: support editing of rule selectors : [Attachment 321902] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 28 15:25:26 PDT 2017


Nikita Vasilyev <nvasilyev at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 177012: Web Inspector: Styles Redesign: support editing of rule selectors
https://bugs.webkit.org/show_bug.cgi?id=177012

Attachment 321902: Patch

https://bugs.webkit.org/attachment.cgi?id=321902&action=review




--- Comment #4 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 321902
  --> https://bugs.webkit.org/attachment.cgi?id=321902
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321902&action=review

>>
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection
.js:300
>> +WI.SpreadsheetSelectorField = class SpreadsheetSelectorField
> 
> This class is likely to change as I'll need to use a similar component for
editable names and values.

After talking to Matt offline, we agreed that I should take a closer look at
the existing EditingSupport.js.


More information about the webkit-reviews mailing list