[webkit-reviews] review granted: [Bug 177614] check in AWS Lambda code used for WebKitArchiveSupport : [Attachment 322110] v1 patch for review

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 177614: check in AWS Lambda code used for WebKitArchiveSupport
https://bugs.webkit.org/show_bug.cgi?id=177614

Attachment 322110: v1 patch for review

https://bugs.webkit.org/attachment.cgi?id=322110&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 322110
  --> https://bugs.webkit.org/attachment.cgi?id=322110
v1 patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=322110&action=review

rs=me, as this code is in production already.

Would be nice to have regression tests for it.

>
Tools/WebKitArchiveSupport/lambda/delete-minified-s3-archive-from-dynamodb.py:3
2
> +	   print('Error deleting item: {}\nfrom database: {}.'.format(item,
table_name))
> +	   raise e

Where do these errors go? How will we notice them?

>
Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:2
6
> +    split_key = key.split('/')
> +    identifier = split_key[0]	   # mac-sierra-x86_64-debug
> +    filename = split_key[1]		   # 218331.zip
> +    revision = filename.split('.')[0]   # 218331

Is there a way to avoid duplicating code?