[webkit-reviews] review granted: [Bug 177610] Small cleanup in RenderMenuList::didUpdateActiveOption : [Attachment 322100] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted zalan <zalan at apple.com>'s request for
review:
Bug 177610: Small cleanup in RenderMenuList::didUpdateActiveOption
https://bugs.webkit.org/show_bug.cgi?id=177610

Attachment 322100: Patch

https://bugs.webkit.org/attachment.cgi?id=322100&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 322100
  --> https://bugs.webkit.org/attachment.cgi?id=322100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322100&action=review

> Source/WebCore/rendering/RenderMenuList.cpp:431
> +    if (m_lastActiveIndex && m_lastActiveIndex == optionIndex)

You learn something every day! I didn't know you could auto cast optional<int>
if you used ==.