[webkit-reviews] review denied: [Bug 177552] Add quota to cache API : [Attachment 322045] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 177552: Add quota to cache API
https://bugs.webkit.org/show_bug.cgi?id=177552

Attachment 322045: Patch

https://bugs.webkit.org/attachment.cgi?id=322045&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 322045
  --> https://bugs.webkit.org/attachment.cgi?id=322045
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322045&action=review

> Source/WebKit/ChangeLog:13
> +	   This size is fuzzed at WebCore for opaque responses.

What does "fuzzed" mean and why are we doing it?

> Source/WebCore/platform/FileSystem.h:107
> -bool fileIsDirectory(const String&, ShouldFollowSymbolicLinks);
> +WEBCORE_EXPORT bool fileIsDirectory(const String&,
ShouldFollowSymbolicLinks);

This isn't used in this patch.

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:318
> +    uint64_t responseBodyFuzzedSize;
> +    if (!decoder.decode(responseBodyFuzzedSize))
> +	   return std::nullopt;

std::optional<uint64_t> responseBodyFuzzedSize;
decoder >> responseBodyFuzzedSize;
if (!responseBodyFuzzedSize)
    return std::nullopt;


Also, I don't think responseBodyFuzzedSize is a good name.  I have no idea what
it is used for based on the name.

> Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:157
> +    uint64_t m_cacheStoragePerOriginQuota { 20000 * 1024 };

20 * 1024 * 1024?

> Tools/WebKitTestRunner/TestController.cpp:35
> +#include <WebCore/FileSystem.h>

This doesn't look needed.

> LayoutTests/ChangeLog:10
> +	   * http/wpt/cache-storage/cache-quota.https.any.js: Added.

I don't think you actually added the test.