[webkit-reviews] review granted: [Bug 174817] [GStreamer] Refactor media player to use MediaTime consistently : [Attachment 321955] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 174817: [GStreamer] Refactor media player to use MediaTime consistently
https://bugs.webkit.org/show_bug.cgi?id=174817

Attachment 321955: Patch

https://bugs.webkit.org/attachment.cgi?id=321955&action=review




--- Comment #28 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 321955
  --> https://bugs.webkit.org/attachment.cgi?id=321955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321955&action=review

Still a nit a thing that was left behind but very good job. Thanks Enrique and
Charlie. We'll live happier lives with this code now.

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:-178
> +    MediaTime current = currentMediaTime();
>      // Avoid useless seeking.
> -    float current = currentMediaTime().toFloat();

Good type change, bad line move.

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:933
> +    return result.toFloat();

This function should not be here. We should be overriding maxMediaTimeSeekable
instead.