[webkit-reviews] review granted: [Bug 177583] Add debug flag to WebKitTestRunner to show where touches are being generated : [Attachment 322055] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 28 01:18:36 PDT 2017


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 177583: Add debug flag to WebKitTestRunner to show where touches are being
generated
https://bugs.webkit.org/show_bug.cgi?id=177583

Attachment 322055: Patch

https://bugs.webkit.org/attachment.cgi?id=322055&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 322055
  --> https://bugs.webkit.org/attachment.cgi?id=322055
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322055&action=review

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:84
> +static const NSUInteger debugTouchDotFrame = debugTouchDotRadius * 2;

“Frame”? Isn’t this a size? Frame is usually a rect.


More information about the webkit-reviews mailing list