[webkit-reviews] review granted: [Bug 177474] Add support for <link rel=preconnect> : [Attachment 322040] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 177474: Add support for <link rel=preconnect>
https://bugs.webkit.org/show_bug.cgi?id=177474

Attachment 322040: Patch

https://bugs.webkit.org/attachment.cgi?id=322040&action=review




--- Comment #22 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 322040
  --> https://bugs.webkit.org/attachment.cgi?id=322040
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322040&action=review

> Source/WebCore/bindings/scripts/IDLAttributes.json:189
> -	       "contextsAllowed": ["interface", "dictionary", "enum"],
> +	       "contextsAllowed": ["interface", "dictionary", "enum",
"callback-function"],

I don't know why you're adding this.

> LayoutTests/platform/mac-wk2/TestExpectations:796
> +# Link preconnect is disabled on ElCapitan because it does not use
NETWORK_SESSION.

What about Sierra and iOS10 where the SPI doesn't exist?