[webkit-reviews] review granted: [Bug 177583] Add debug flag to WebKitTestRunner to show where touches are being generated : [Attachment 322049] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 177583: Add debug flag to WebKitTestRunner to show where touches are being
generated
https://bugs.webkit.org/show_bug.cgi?id=177583

Attachment 322049: Patch

https://bugs.webkit.org/attachment.cgi?id=322049&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 322049
  --> https://bugs.webkit.org/attachment.cgi?id=322049
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322049&action=review

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:162
> +    BOOL _shouldInitDebugViews;

Do we need this, or can we just check debugTouchViews?

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:200
> +	   if ([[UIApplication sharedApplication] keyWindow])
> +	       [self initDebugViews];
> +	   else

Is there any reason to eagerly do it at this point? We don't support
dynamically changing it (e.g. nothing ever removes views), which is fine, so
shouldn't we just depend on the lazy loading mechanism always?

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:205
> +- (void)initDebugViews

This is now an "-IfNeeded"

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:207
> +    if (self.shouldShowTouches && _shouldInitDebugViews) {

Should be an early return :)