[webkit-reviews] review granted: [Bug 172526] Drag event DataTransfer has unexpected types "dyn.ah62d4..." : [Attachment 322022] Address more review feedback, and rebase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 27 15:52:30 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 172526: Drag event DataTransfer has unexpected types "dyn.ah62d4..."
https://bugs.webkit.org/show_bug.cgi?id=172526

Attachment 322022: Address more review feedback, and rebase

https://bugs.webkit.org/attachment.cgi?id=322022&action=review




--- Comment #46 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 322022
  --> https://bugs.webkit.org/attachment.cgi?id=322022
Address more review feedback, and rebase

View in context: https://bugs.webkit.org/attachment.cgi?id=322022&action=review

> Source/WebCore/platform/Pasteboard.cpp:49
> +    encoder << data.sameOriginCustomData;

Could you add an empty origin here so that we don't have to change the encoded
data format when we add the origin check?
It would be silly having to bump up the version number just to deal with people
using spades/STP.

> Source/WebCore/platform/mac/PasteboardMac.mm:584
> +String platformPasteboardTypeForSafeTypeForDOMToReadAndWrite(const String&
domType)

Looks like this should just be a public static member function of
PlatformPasteboard. It even says PlatformPasteboard in its name!


More information about the webkit-reviews mailing list