[webkit-reviews] review granted: [Bug 177511] Make it possible to easily get verbose ninja output from build-webkit : [Attachment 321880] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 177511: Make it possible to easily get verbose ninja output from
build-webkit
https://bugs.webkit.org/show_bug.cgi?id=177511

Attachment 321880: Patch

https://bugs.webkit.org/attachment.cgi?id=321880&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 321880
  --> https://bugs.webkit.org/attachment.cgi?id=321880
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321880&action=review

Seems fine. Kind of weird using ENV to communicate to
buildCMakeGeneratedProject. Seems like passing an argument would be clearer.

> Tools/ChangeLog:15
> +	   Add Ninja verbosity arguments to @makeArgs, which are appended
> +	   after the -- and thus handed to ninja; the previous implementation

Inconsistent on capitalization of Ninja.