[webkit-reviews] review granted: [Bug 177514] Web Automation: overflow:hidden elements with no children are mistakenly reported as not visible : [Attachment 321883] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 26 16:14:27 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 177514: Web Automation: overflow:hidden elements with no children are
mistakenly reported as not visible
https://bugs.webkit.org/show_bug.cgi?id=177514
Attachment 321883: Patch
https://bugs.webkit.org/attachment.cgi?id=321883&action=review
--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 321883
--> https://bugs.webkit.org/attachment.cgi?id=321883
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=321883&action=review
r=me
> Source/WebKit/ChangeLog:12
> + to check for the case where the element has no children and return
'false'.
I'd use backticks `false` to avoid string confusion, but this is a ChangeLog
after all, so whatever.
More information about the webkit-reviews
mailing list