[webkit-reviews] review granted: [Bug 177498] AX: ARIA grids claim to be multiselectable even with aria-multiselectable is set to false : [Attachment 321855] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 26 14:50:37 PDT 2017


chris fleizach <cfleizach at apple.com> has granted Joanmarie Diggs (irc: joanie)
<jdiggs at igalia.com>'s request for review:
Bug 177498: AX: ARIA grids claim to be multiselectable even with
aria-multiselectable is set to false
https://bugs.webkit.org/show_bug.cgi?id=177498

Attachment 321855: Patch

https://bugs.webkit.org/attachment.cgi?id=321855&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 321855
  --> https://bugs.webkit.org/attachment.cgi?id=321855
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321855&action=review

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:88
> +    if (equalLettersIgnoringASCIICase(ariaMultiSelectable, "false"))

I think you can write just like

return !equalLettersIgnoringASCIICase(ariaMultiSelectable, "false");


More information about the webkit-reviews mailing list