[webkit-reviews] review granted: [Bug 177493] Extract out combined text query into a member function : [Attachment 321848] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Daniel Bates <dbates at webkit.org>'s request
for review:
Bug 177493: Extract out combined text query into a member function
https://bugs.webkit.org/show_bug.cgi?id=177493

Attachment 321848: Patch

https://bugs.webkit.org/attachment.cgi?id=321848&action=review




--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 321848
  --> https://bugs.webkit.org/attachment.cgi?id=321848
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321848&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:1117
> +    return lineStyle().hasTextCombine() && is<RenderCombineText>(renderer())
&& downcast<RenderCombineText>(renderer()).isCombined() ?
&downcast<RenderCombineText>(renderer()) : nullptr;

Not sure why we check both the style and the type of the renderer here. If the
style has text combine, the renderer is supposed to be RenderCombineText (and
vice versa). Also do you mind checking if fontToUse() could take advantage of
this change -it's a static function though).