[webkit-reviews] review granted: [Bug 177403] Add helper functions to write better selection tests : [Attachment 321783] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 26 12:43:45 PDT 2017


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 177403: Add helper functions to write better selection tests
https://bugs.webkit.org/show_bug.cgi?id=177403

Attachment 321783: Patch

https://bugs.webkit.org/attachment.cgi?id=321783&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 321783
  --> https://bugs.webkit.org/attachment.cgi?id=321783
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321783&action=review

> LayoutTests/fast/events/touch/ios/resources/ui-debugging.js:18
> +    dot.style.left = (x-dotSize/2)+"px";

spaces around math operators!

> LayoutTests/fast/events/touch/ios/resources/ui-debugging.js:46
> +    rect.style.top = y+"px";

ditto, etc.


More information about the webkit-reviews mailing list