[webkit-reviews] review granted: [Bug 177480] Make PolicyAction an encodable enum class : [Attachment 321789] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 177480: Make PolicyAction an encodable enum class
https://bugs.webkit.org/show_bug.cgi?id=177480

Attachment 321789: Patch

https://bugs.webkit.org/attachment.cgi?id=321789&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 321789
  --> https://bugs.webkit.org/attachment.cgi?id=321789
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321789&action=review

> Source/WebKit/UIProcess/WebPageProxy.messages.in:102
> +    DecidePolicyForNavigationAction(uint64_t frameID, struct
WebCore::SecurityOriginData frameSecurityOrigin, uint64_t navigationID, struct
WebKit::NavigationActionData navigationActionData, struct WebKit::FrameInfoData
originatingFrameInfoData, uint64_t originatingPageID, WebCore::ResourceRequest
originalRequest, WebCore::ResourceRequest request, uint64_t listenerID,
WebKit::UserData userData) -> (uint64_t newNavigationID, enum
WebCore::PolicyAction policyAction, WebKit::DownloadID downloadID, struct
WebKit::WebsitePolicies websitePolicies) Delayed

Would be nice make these sane at some point (by packing all the million
arguments into a struct for example).