[webkit-reviews] review granted: [Bug 177469] Web Inspector: Add loading indicator next to resources in the Network Tab : [Attachment 321756] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 177469: Web Inspector: Add loading indicator next to resources in the
Network Tab
https://bugs.webkit.org/show_bug.cgi?id=177469

Attachment 321756: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=321756&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 321756
  --> https://bugs.webkit.org/attachment.cgi?id=321756
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=321756&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Resource.js:847
> +    {

I'd make this a read-only property and put it after
`Resource.prototype.finished get`.

> Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js:318
> +	   } else {

Could be:

} else if (this._spinner) {