[webkit-reviews] review granted: [Bug 177431] Update compressedTexImage3D to match the signature in the specification. : [Attachment 321680] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Ms2ger <Ms2ger at igalia.com>'s request
for review:
Bug 177431: Update compressedTexImage3D to match the signature in the
specification.
https://bugs.webkit.org/show_bug.cgi?id=177431

Attachment 321680: Patch

https://bugs.webkit.org/attachment.cgi?id=321680&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 321680
  --> https://bugs.webkit.org/attachment.cgi?id=321680
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321680&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.h:76
> +    void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum
internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint
border, RefPtr<ArrayBufferView>&& srcData, GC3Duint srcOffset, GC3Duint
srcLengthOverride);

The ArrayBuffer can probably be a ArrayBufferView&, since the IDL parameter is
not nullable.