[webkit-reviews] review granted: [Bug 177457] [WebIDL] Factor out IsExceptionOr check from toJS/toJSNewlyCreated signature : [Attachment 321727] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 25 14:01:31 PDT 2017
youenn fablet <youennf at gmail.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 177457: [WebIDL] Factor out IsExceptionOr check from toJS/toJSNewlyCreated
signature
https://bugs.webkit.org/show_bug.cgi?id=177457
Attachment 321727: Patch
https://bugs.webkit.org/attachment.cgi?id=321727&action=review
--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 321727
--> https://bugs.webkit.org/attachment.cgi?id=321727
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=321727&action=review
> Source/WebCore/bindings/js/JSDOMConvertBase.h:91
> +struct IsExceptionOr : public std::integral_constant<bool,
WTF::IsTemplate<std::decay_t<T>, ExceptionOr>::value> { };
Would the following work?
template<typename T> using IsExceptionOr = std::integral_constant...
More information about the webkit-reviews
mailing list