[webkit-reviews] review granted: [Bug 177437] Add High Sierra bots to buildbot and dashboard : [Attachment 321715] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Ryan Haddad
<ryanhaddad at apple.com>'s request for review:
Bug 177437: Add High Sierra bots to buildbot and dashboard
https://bugs.webkit.org/show_bug.cgi?id=177437

Attachment 321715: Patch

https://bugs.webkit.org/attachment.cgi?id=321715&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 321715
  --> https://bugs.webkit.org/attachment.cgi?id=321715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321715&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:170
> +			 "triggers": ["sierra-release-tests-wk1",
"sierra-release-tests-wk2", "sierra-leaks"],

I think that "sierra-leaks" needs to be removed too.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:411
>			 "builderNames": ["Apple Sierra Release (Build)",
"Apple Sierra Debug (Build)", "Apple Sierra Release (32-bit Build)", "Apple
Sierra LLINT CLoop (BuildAndTest)", "Apple Sierra 32-bit JSC (BuildAndTest)"]

I think that some of these need to be removed (JSC, 32-bit).