[webkit-reviews] review denied: [Bug 177298] [WebVR] Add OpenVR to the tree and to the build : [Attachment 321682] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 25 12:38:48 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 177298: [WebVR] Add OpenVR to the tree and to the build
https://bugs.webkit.org/show_bug.cgi?id=177298

Attachment 321682: Patch

https://bugs.webkit.org/attachment.cgi?id=321682&action=review




--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 321682
  --> https://bugs.webkit.org/attachment.cgi?id=321682
Patch

If Valve isn't shipping a usable library, then you can fork this on GitHub or
someplace else and we can depend on that.

I don't want to allow any new dependencies in ThirdParty. ANGLE is bad enough,
now we have brotli (unacceptable) and woff2 (also unacceptable) and libwebrtc
(if a fork is really necessary, that could still be done in an external
repo)... where does it stop?


More information about the webkit-reviews mailing list