[webkit-reviews] review granted: [Bug 177406] Images may render partial frames even after loading all the encoded data : [Attachment 321622] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 177406: Images may render partial frames even after loading all the encoded
data
https://bugs.webkit.org/show_bug.cgi?id=177406

Attachment 321622: Patch

https://bugs.webkit.org/attachment.cgi?id=321622&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 321622
  --> https://bugs.webkit.org/attachment.cgi?id=321622
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321622&action=review

> Source/WTF/wtf/SynchronizedFixedQueue.h:43
>      SynchronizedFixedQueue()

This constructor should be private now.

> Source/WebCore/platform/graphics/ImageFrameCache.cpp:327
> +    ASSERT(m_frameRequestQueue);
> +    m_frameRequestQueue->enqueue({ index, subsamplingLevel, sizeForDrawing,
decodingStatus });

The ASSERT is pointless because you'll crash on the next line anyway.