[webkit-reviews] review granted: [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI : [Attachment 321600] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 22 18:22:41 PDT 2017
Ryosuke Niwa <rniwa at webkit.org> has granted Frederik Riedel
<riedel at apple.com>'s request for review:
Bug 174394: Expose way to set values of classified form controls as {Legacy
WebKit, WebKit} SPI
https://bugs.webkit.org/show_bug.cgi?id=174394
Attachment 321600: Patch
https://bugs.webkit.org/attachment.cgi?id=321600&action=review
--- Comment #55 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 321600
--> https://bugs.webkit.org/attachment.cgi?id=321600
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=321600&action=review
> Source/WebCore/editing/ios/AutofillElements.h:36
> + AutofillElements(RefPtr<HTMLInputElement>, RefPtr<HTMLInputElement>);
Use RefPtr<HTMLInputElement>&& instead to avoid ref churn.
> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2816
> + Ref<HTMLInputElement> assistendElement =
downcast<HTMLInputElement>(*m_assistedNode);
> + auto autofillElements =
AutofillElements::computeAutofillElements(assistendElement.get());
It looks like we don't need this local variable?
Why not just do this?:
AutofillElements::computeAutofillElements(downcast<HTMLInputElement>(*m_assiste
dNode));
> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:37
> +// FIXME 34583628: Simplyfy this once the UIKit work is available in the
build.
Nit: "FIXME <radar:34583628>: ~"
More information about the webkit-reviews
mailing list