[webkit-reviews] review granted: [Bug 177092] WSL should report an error if you try to create an operator overload that will never be called : [Attachment 321573] the patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 177092: WSL should report an error if you try to create an operator
overload that will never be called
https://bugs.webkit.org/show_bug.cgi?id=177092

Attachment 321573: the patch

https://bugs.webkit.org/attachment.cgi?id=321573&action=review




--- Comment #11 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 321573
  --> https://bugs.webkit.org/attachment.cgi?id=321573
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321573&action=review

r=me

> Tools/WebGPUShadingLanguageRI/FuncInstantiator.js:97
> +	   class InstantiationInstantiateImmediates extends
InstantiateImmediates {

InstantiationInstantiateImmediates 🤔

> Tools/WebGPUShadingLanguageRI/Prepare.js:32
> +	       parse(standardProgram, "/internal/stdlib", "native", 28 - 1,
standardLibrary);

What's that number?

> Tools/WebGPUShadingLanguageRI/StandardLibrary.js:27
> +// NOTE: The next line is line 28, and we rely on this in Prepare.js.

Ah OK.