[webkit-reviews] review requested: [Bug 177092] WSL should report an error if you try to create an operator overload that will never be called : [Attachment 321572] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 22 11:52:29 PDT 2017


Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 177092: WSL should report an error if you try to create an operator
overload that will never be called
https://bugs.webkit.org/show_bug.cgi?id=177092

Attachment 321572: the patch

https://bugs.webkit.org/attachment.cgi?id=321572&action=review




--- Comment #7 from Filip Pizlo <fpizlo at apple.com> ---
Created attachment 321572

  --> https://bugs.webkit.org/attachment.cgi?id=321572&action=review

the patch

My test hacking spree ended up uncovering some bugs in type instantiation.  I
then fixed those bugs.

Basically, even if we instantiate a Func, we need its CallExpressions to retain
the original uninstantiated types for the purpose of reresolving protocol
function calls.


More information about the webkit-reviews mailing list