[webkit-reviews] review granted: [Bug 177295] [GTK] Couple of pasteboard related tests are failing after r222228 : [Attachment 321536] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 22 07:17:12 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Ms2ger
<Ms2ger at igalia.com>'s request for review:
Bug 177295: [GTK] Couple of pasteboard related tests are failing after r222228
https://bugs.webkit.org/show_bug.cgi?id=177295

Attachment 321536: Patch

https://bugs.webkit.org/attachment.cgi?id=321536&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 321536
  --> https://bugs.webkit.org/attachment.cgi?id=321536
Patch

Good job, thanks!

The only thing I'm not sure about is why r222228 caused this regression, but
it's clear that not calling writeToClipboard() is bad.


More information about the webkit-reviews mailing list