[webkit-reviews] review granted: [Bug 174582] [GTK] HTMLMediaElement resize event not fired when video size changes : [Attachment 321527] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Nael Ouedraogo
<nael.ouedp at gmail.com>'s request for review:
Bug 174582: [GTK] HTMLMediaElement resize event not fired when video size
changes
https://bugs.webkit.org/show_bug.cgi?id=174582

Attachment 321527: Patch

https://bugs.webkit.org/attachment.cgi?id=321527&action=review




--- Comment #10 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 321527
  --> https://bugs.webkit.org/attachment.cgi?id=321527
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321527&action=review

On top of Enrique's, I add two small change requests.

> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:303
> +void PlaybackPipeline::reattachTrack(RefPtr<SourceBufferPrivateGStreamer>
sourceBufferPrivate, RefPtr<TrackPrivateBase> trackPrivate, const gchar*
mediaType)

gchar -> char

> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.h:61
> +    void reattachTrack(RefPtr<SourceBufferPrivateGStreamer>,
RefPtr<TrackPrivateBase>, const gchar*);

gchar -> char