[webkit-reviews] review granted: [Bug 177130] [css-grid] Small refactoring adding RenderGrid::contentAlignment() : [Attachment 321197] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 22 02:46:35 PDT 2017


Sergio Villar Senin <svillar at igalia.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 177130: [css-grid] Small refactoring adding RenderGrid::contentAlignment()
https://bugs.webkit.org/show_bug.cgi?id=177130

Attachment 321197: Patch

https://bugs.webkit.org/attachment.cgi?id=321197&action=review




--- Comment #7 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 321197
  --> https://bugs.webkit.org/attachment.cgi?id=321197
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321197&action=review

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:1078
> +	   || (m_renderGrid->contentAlignment(m_direction).distribution() !=
ContentDistributionStretch))

Very nice. Do we still need resolvedJustifyContentPosition() and
resolvedJustifyContentDistribution() ?


More information about the webkit-reviews mailing list