[webkit-reviews] review granted: [Bug 177051] [DFG][FTL] Profile array vector length for array allocation : [Attachment 321460] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 177051: [DFG][FTL] Profile array vector length for array allocation
https://bugs.webkit.org/show_bug.cgi?id=177051

Attachment 321460: Patch

https://bugs.webkit.org/attachment.cgi?id=321460&action=review




--- Comment #20 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 321460
  --> https://bugs.webkit.org/attachment.cgi?id=321460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321460&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   Currently, NewArrayBuffer allocation is penaltized by JSC: While
empty array gets 25 vector size (BASE_CONTIGUOUS_VECTOR_LEN),

penaltized=>penalized

> Source/JavaScriptCore/ChangeLog:31
> +	   we should allocate 3 - 25 vector size if it is likely grown. So we
should get profile on the resulted array.

what does "3 - 25" mean here? 3 to 25 or 3 minus 25? I think you mean the
former, maybe just say "to" instead of "-"

> Source/JavaScriptCore/ChangeLog:36
> +	   If the number of new_array_buffer constants is <= 25, array vector
size would become 3-25 based on profiling. If the number of its constants

I'd say "to" instead of "-" here as well.