[webkit-reviews] review granted: [Bug 175364] [GTK] Web Inspector: Add Canvas2D.svg and Canvas3D.svg : [Attachment 321508] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 22 00:11:28 PDT 2017
Carlos Garcia Campos <cgarcia at igalia.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 175364: [GTK] Web Inspector: Add Canvas2D.svg and Canvas3D.svg
https://bugs.webkit.org/show_bug.cgi?id=175364
Attachment 321508: Patch
https://bugs.webkit.org/attachment.cgi?id=321508&action=review
--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 321508
--> https://bugs.webkit.org/attachment.cgi?id=321508
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=321508&action=review
Thanks!
> Tools/Scripts/webkitdirs.pm:1977
> + if (isGtk() or isWPE()) {
> + my $gtkImageDircetory = File::Spec->catdir(sourceDir(), "Source",
"WebInspectorUI", "UserInterface", "Images", "gtk");
> + if ($cacheFileModifiedTime < stat($gtkImageDircetory)->mtime) {
> + return 1;
> + }
> + }
This is a great idea! but I don't think it belongs to this commit. Could you
please move this to its own bug/patch? You can submit the patch already
reviewed and only ask for cq?
More information about the webkit-reviews
mailing list