[webkit-reviews] review denied: [Bug 168219] [GTK] Expose editing command availability in WebKitHitTestResult : [Attachment 321510] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 168219: [GTK] Expose editing command availability in WebKitHitTestResult
https://bugs.webkit.org/show_bug.cgi?id=168219

Attachment 321510: Patch

https://bugs.webkit.org/attachment.cgi?id=321510&action=review




--- Comment #27 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 321510
  --> https://bugs.webkit.org/attachment.cgi?id=321510
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321510&action=review

r- because exposing editor states in HitTestResult is a clear layering
violation.

> Source/WebKit/ChangeLog:13
> +	   I want to fix a context menu flickering problem in Epiphany. Since
we have to show the
> +	   WebKitContextMenu in a WebKitWebView::context-menu handler, but
cannot check the
> +	   availability of editing commands there without using sync IPC, we
currently assume all
> +	   editing commands are available, add them to the menu, start querying
the availability with
> +	   webkit_web_view_can_execute_editing_command(), show the menu, and
later remove them from the
> +	   menu once that finishes, causing the flicker.

You should be able to do that by checking EditorState.
If not, we should be sending EditorState update as we tell UI process to show
the context menu.