[webkit-reviews] review granted: [Bug 177099] Remove the need for SetterMayThrowException : [Attachment 321457] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 177099: Remove the need for SetterMayThrowException
https://bugs.webkit.org/show_bug.cgi?id=177099

Attachment 321457: Patch

https://bugs.webkit.org/attachment.cgi?id=321457&action=review




--- Comment #12 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 321457
  --> https://bugs.webkit.org/attachment.cgi?id=321457
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321457&action=review

> Source/WebCore/ChangeLog:56
> +	   * bindings/scripts/test/JS/JSTestObj.cpp:
> +	   (WebCore::setJSTestObjConstructorStaticStringAttrSetter):
> +	   (WebCore::setJSTestObjEnumAttrSetter):
> +	   (WebCore::setJSTestObjByteAttrSetter):
> +	   (WebCore::setJSTestObjOctetAttrSetter):
> +	   (WebCore::setJSTestObjShortAttrSetter):
> +	   (WebCore::setJSTestObjClampedShortAttrSetter):

I think you can remove some of these function names that changed in test result
lines.

> Source/WebCore/bindings/js/JSDOMAttribute.h:111
> +    static void call(JSC::ExecState&, JSC::ThrowScope&, Functor&& functor) {
functor(); }

This should use the normal syntax, braces on their own lines.